[Merged by Bors] - feat: port Data.Finset.NoncommProd #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHughes24
added
WIP
ChrisHughes24
added
awaiting-review
|
✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with |
semorrison
added
delegated
and removed
awaiting-review
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
jcommelin
pushed a commit
that referenced
this pull request
Jan 23, 2023
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a very nice port. I don't think it's a well written file in the first place, maybe it should be refactored at some point because all of these lemmas follow from the corresponding
Finset.prodlemma and the fact that the submonoid/subring generated by commuting elements is commutative. Too many dependent rewrites in this file.