Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.BigOperators.Pi #1687

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Algebra.BigOperators.Pi #1687

wants to merge 11 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Jan 19, 2023 •
edited

Open in Gitpod

@xroblot
feat: port Algebra.BigOperators.Pi
eb299a6
@xroblot
Initial file copy from mathport
f0ded4c
@xroblot
automated fixes
7a9c136 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@xroblot xroblot added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 19, 2023
@xroblot xroblot mentioned this pull request Jan 19, 2023
Closed
@xroblot xroblot added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 20, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 20, 2023
@xroblot xroblot removed the awaiting-review The author would like community review of the PR label Jan 20, 2023
@ChrisHughes24
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Jan 20, 2023

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 20, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 20, 2023
@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jan 20, 2023
@xroblot @ChrisHughes24
feat: port Algebra.BigOperators.Pi (#1687)
8176e5d 
 


Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Jan 20, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.BigOperators.Pi [Merged by Bors] - feat: port Algebra.BigOperators.Pi Jan 20, 2023
@bors bors bot closed this Jan 20, 2023
@bors bors bot deleted the port/Algebra.BigOperators.Pi branch January 20, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xroblot @ChrisHughes24 @semorrison