Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Combinatorics.HalesJewett #1704

Closed
wants to merge 22 commits into from
Closed

[Merged by Bors] - feat: port Combinatorics.HalesJewett #1704

wants to merge 22 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jan 20, 2023

Open in Gitpod

@mo271
feat: port Combinatorics.HalesJewett
7d2b022
@mo271
Initial file copy from mathport
386d24e
@mo271
automated fixes
a3e3aa2 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mo271
starting
ffb1957
@mo271 mo271 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 20, 2023
@mo271 mo271 changed the title Port/combinatorics.hales jewett feat: port Combinatorics.HalesJewett Jan 20, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 20, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jan 21, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 24, 2023
@mo271 mo271 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jan 27, 2023
@LukasMias LukasMias removed the help-wanted The author needs attention to resolve issues label Jan 29, 2023
@LukasMias LukasMias added the awaiting-review The author would like community review of the PR label Jan 29, 2023
@ChrisHughes24 ChrisHughes24 added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 30, 2023
@dwarn dwarn added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 16, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 21, 2023
bors bot pushed a commit that referenced this pull request Feb 21, 2023
@mo271 @LukasMias
@dwarn @jcommelin
feat: port Combinatorics.HalesJewett (#1704)
f2e18b2 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com>
Co-authored-by: David Wärn <codwarn@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Combinatorics.HalesJewett [Merged by Bors] - feat: port Combinatorics.HalesJewett Feb 21, 2023
@bors bors bot closed this Feb 21, 2023
@bors bors bot deleted the port/Combinatorics.HalesJewett branch February 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@dwarn dwarn dwarn left review comments

@dupuisf dupuisf dupuisf left review comments

@ChrisHughes24 ChrisHughes24 ChrisHughes24 left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mo271 @jcommelin @dwarn @dupuisf @ChrisHughes24 @semorrison @LukasMias