Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.ZMod.Defs #1713

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - feat: port Data.ZMod.Defs #1713

wants to merge 18 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port Data.Zmod.Defs
3446eea
@Ruben-VandeVelde
Initial file copy from mathport
03bb6df
@Ruben-VandeVelde
automated fixes
da3120d 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@Ruben-VandeVelde Ruben-VandeVelde added the mathlib-port This is a port of a theory file from mathlib. label Jan 20, 2023
@Ruben-VandeVelde Ruben-VandeVelde added the help-wanted The author needs attention to resolve issues label Jan 20, 2023
eric-wieser
eric-wieser reviewed Jan 20, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use the output of mathlib3port or the ad-hoc content here? The intent was for the adhoc code to be discarded entirely.

Mathlib/Data/Zmod/Defs.lean Outdated Show resolved Hide resolved
@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 20, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 20, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 22, 2023
@eric-wieser
Copy link
Member

Was the Zulip consensus to use Zmod or ZMod?

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues awaiting-author A reviewer has asked the author a question or requested changes labels Jan 22, 2023
@Ruben-VandeVelde
Copy link
Collaborator Author

Thanks!

Ruben-VandeVelde
Ruben-VandeVelde commented Jan 23, 2023
View reviewed changes
Mathlib/Data/Zmod/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Data/Zmod/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Data/Zmod/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Data/Zmod/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Data/Zmod/Defs.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin reviewed Jan 23, 2023
View reviewed changes
Mathlib/Data/Zmod/Defs.lean Outdated Show resolved Hide resolved
scripts/start_port.sh Outdated Show resolved Hide resolved
jcommelin
jcommelin reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Jan 23, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 23, 2023
@Ruben-VandeVelde Ruben-VandeVelde changed the title feat: port Data.Zmod.Defs feat: port Data.ZMod.Defs Jan 23, 2023
eric-wieser
eric-wieser approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@semorrison semorrison added the ready-to-merge This PR has been sent to bors. label Jan 23, 2023
bors bot pushed a commit that referenced this pull request Jan 23, 2023
@Ruben-VandeVelde @eric-wieser
feat: port Data.ZMod.Defs (#1713)
755274f 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Jan 23, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.ZMod.Defs [Merged by Bors] - feat: port Data.ZMod.Defs Jan 23, 2023
@bors bors bot closed this Jan 23, 2023
@bors bors bot deleted the port/Data.Zmod.Defs branch January 23, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@qawbecrdtey qawbecrdtey qawbecrdtey left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ruben-VandeVelde @eric-wieser @jcommelin @qawbecrdtey @semorrison