Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Finite.Basic #1722

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Data.Finite.Basic #1722

wants to merge 7 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin
feat: port Data.Finite.Basic
98a4458
@jcommelin
Initial file copy from mathport
8c6a07a
@jcommelin
automated fixes
ea4bd37 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@jcommelin jcommelin added the mathlib-port This is a port of a theory file from mathlib. label Jan 20, 2023
@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Jan 20, 2023
eric-wieser
eric-wieser approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/leanprover-community/mathlib4/pull/1722/files/8c6a07adde9cd684544daeb3e1ea79a4c59586f3..15aaa6deb366552dd16769dc4567e02e30e517bd looks good to me, though I don't understand the porting note.

bors d+

@bors
Copy link

bors bot commented Jan 20, 2023

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 20, 2023
@jcommelin
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 20, 2023
bors bot pushed a commit that referenced this pull request Jan 20, 2023
@jcommelin
feat: port Data.Finite.Basic (#1722)
9cb699a
@jcommelin @eric-wieser
Update Mathlib/Data/Finite/Basic.lean
8dd600d 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Jan 20, 2023

Canceled.

@jcommelin
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 20, 2023
@jcommelin
feat: port Data.Finite.Basic (#1722)
2847b3b
@bors
Copy link

bors bot commented Jan 20, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Finite.Basic [Merged by Bors] - feat: port Data.Finite.Basic Jan 20, 2023
@bors bors bot closed this Jan 20, 2023
@bors bors bot deleted the port/Data.Finite.Basic branch January 20, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @eric-wieser @semorrison