Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/list/alist): recursion on alist using insert #1724

Closed
wants to merge 7 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jan 20, 2023

@vihdzp vihdzp added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label Jan 20, 2023
@vihdzp vihdzp marked this pull request as ready for review February 28, 2023 06:10
@eric-wieser
Copy link
Member

This needs the mathlib SHA (which would have been in the mathport file you copied from) in the header.

@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 18, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes needs-mathlib-SHA labels Mar 18, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these files had an earlier pending forward-port that I've marked as dependent. Otherwise looks good.

bors d+

Mathlib/Data/List/AList.lean Outdated Show resolved Hide resolved
Mathlib/Data/List/AList.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 21, 2023

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Mar 21, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Mar 21, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 21, 2023
@eric-wieser eric-wieser removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 21, 2023
@eric-wieser
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 21, 2023
bors bot pushed a commit that referenced this pull request Mar 21, 2023
Mathlib4 pair for leanprover-community/mathlib#15434



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Mar 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/list/alist): recursion on alist using insert [Merged by Bors] - feat(data/list/alist): recursion on alist using insert Mar 21, 2023
@bors bors bot closed this Mar 21, 2023
@bors bors bot deleted the alist_recursion branch March 21, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
No open projects
Status: Awaiting mathport output
Development

Successfully merging this pull request may close these issues.

None yet

4 participants