Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Set.Finite #1734

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: port Data.Set.Finite #1734

wants to merge 19 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin
feat: port Data.Set.Finite
ff2ff73
@jcommelin
Initial file copy from mathport
926284e
@jcommelin
automated fixes
25e8465 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@jcommelin jcommelin added the mathlib-port This is a port of a theory file from mathlib. label Jan 20, 2023
@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Jan 21, 2023
jcommelin
jcommelin commented Jan 21, 2023
View reviewed changes
Mathlib/Data/Set/Finite.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Finite.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Finite.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Finite.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Finite.lean Outdated Show resolved Hide resolved
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 21, 2023
bors bot pushed a commit that referenced this pull request Jan 21, 2023
@jcommelin @Ruben-VandeVelde
@ericrbg @urkud
feat: port Data.Set.Finite (#1734)
e1f2a66 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Eric Rodriguez <ericrboidi@gmail.com>
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Jan 21, 2023

Build failed:

  • Build

@ChrisHughes24
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 21, 2023
@jcommelin @Ruben-VandeVelde
@ericrbg @urkud @ChrisHughes24
feat: port Data.Set.Finite (#1734)
5841a8d 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Eric Rodriguez <ericrboidi@gmail.com>
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Jan 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Set.Finite [Merged by Bors] - feat: port Data.Set.Finite Jan 21, 2023
@bors bors bot closed this Jan 21, 2023
@bors bors bot deleted the port/Data.Set.Finite branch January 21, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericrbg ericrbg ericrbg left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcommelin @ChrisHughes24 @ericrbg @Ruben-VandeVelde @urkud