Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - port/Algebra.Group.ConjFinite #1737

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - port/Algebra.Group.ConjFinite #1737

wants to merge 4 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Jan 20, 2023

  • feat: port Algebra.Group.ConjFinite
  • Initial file copy from mathport
  • automated fixes

Open in Gitpod

@ericrbg
feat: port Algebra.Group.ConjFinite
180681b
@ericrbg
Initial file copy from mathport
c5037b6
@ericrbg
automated fixes
9aebc37 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@ericrbg ericrbg added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 20, 2023
@ericrbg ericrbg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. and removed WIP Work in progress labels Jan 20, 2023
jcommelin
jcommelin approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 20, 2023
bors bot pushed a commit that referenced this pull request Jan 20, 2023
@ericrbg
port/Algebra.Group.ConjFinite (#1737)
2d1d054 
- feat: port Algebra.Group.ConjFinite
- Initial file copy from mathport
- automated fixes
@bors
Copy link

bors bot commented Jan 20, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title port/Algebra.Group.ConjFinite [Merged by Bors] - port/Algebra.Group.ConjFinite Jan 20, 2023
@bors bors bot closed this Jan 20, 2023
@bors bors bot deleted the port/Algebra.Group.ConjFinite branch January 20, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericrbg @jcommelin @semorrison