Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.ConditionallyCompleteLattice.Finset #1748

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Order.ConditionallyCompleteLattice.Finset #1748

wants to merge 8 commits into from

Conversation

ChrisHughes24
Copy link
Member

easy

Open in Gitpod

@ChrisHughes24
feat: port Order.ConditionallyCompleteLattice.Finset
12051c2
@ChrisHughes24
Initial file copy from mathport
fb7e677
@ChrisHughes24
automated fixes
c681f0a 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@ChrisHughes24
fixed
d4d070d
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Jan 21, 2023
jcommelin
jcommelin reviewed Jan 21, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/Order/ConditionallyCompleteLattice/Finset.lean Outdated Show resolved Hide resolved
Mathlib/Order/ConditionallyCompleteLattice/Finset.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 21, 2023

✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 21, 2023
@jcommelin
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 21, 2023
bors bot pushed a commit that referenced this pull request Jan 21, 2023
@ChrisHughes24 @jcommelin
feat: port Order.ConditionallyCompleteLattice.Finset (#1748)
30c54b4 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jan 21, 2023

Build failed:

  • Build

@ChrisHughes24
Copy link
Member Author

bors r-

@ChrisHughes24
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 21, 2023
@ChrisHughes24 @jcommelin
feat: port Order.ConditionallyCompleteLattice.Finset (#1748)
1ec531b 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jan 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.ConditionallyCompleteLattice.Finset [Merged by Bors] - feat: port Order.ConditionallyCompleteLattice.Finset Jan 21, 2023
@bors bors bot closed this Jan 21, 2023
@bors bors bot deleted the port/Order.ConditionallyCompleteLattice.Finset branch January 21, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisHughes24 @jcommelin @semorrison