[Merged by Bors] - feat : port Algebra.Star.Pointwise #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xroblot
commented
Jan 21, 2023
xroblot
commented
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
xroblot
added
WIP
Ruben-VandeVelde
added
awaiting-review
|
@Ruben-VandeVelde Thanks for the fix! |
Ruben-VandeVelde
approved these changes
Jan 22, 2023
jcommelin
reviewed
Jan 23, 2023
| @@ -297,7 +297,7 @@ protected def mul : Mul (Set α) := | |||
| scoped[Pointwise] attribute [instance] Set.mul Set.add | |||
|
|
|||
| @[to_additive (attr := simp)] | |||
| theorem image2_mul : image2 Mul.mul s t = s * t := | |||
| theorem image2_mul : image2 (· * ·) s t = s * t := | |||
There was a problem hiding this comment.
Otherwise, the proof of star_mul gets more complicated since at some point, one needs to prove that
(fun a b : α ↦ (Mul.mul a b)⋆) = (fun a b : α ↦ b⋆ * a⋆)
Note that I was the one that did the porting of Data/Pointwise/Basic so it is likely that I wrote the wrong statement. The original mathlib3 lemma is:
lemma image2_mul : image2 has_mul.mul s t = s * t := rfl
This change was suggested by @Ruben-VandeVelde
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.