Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Feat: port Order.Filter.Basic #1750

Closed
wants to merge 40 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 21, 2023


Open in Gitpod

@urkud urkud changed the title Port order.filter.basic Feat: port Order.Filter.Basic Jan 21, 2023
@jcommelin jcommelin added the mathlib-port This is a port of a theory file from mathlib. label Jan 21, 2023
@urkud urkud added the awaiting-review The author would like community review of the PR label Jan 22, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some naming fixes in the module docstring.

Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed docstring till L890.

Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Co-authored-by: Johan Commelin <johan@commelin.net>
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish reviewing comments.

Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Basic.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors d+

@bors
Copy link

bors bot commented Jan 23, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 23, 2023
Co-authored-by: Johan Commelin <johan@commelin.net>
@urkud
Copy link
Member Author

urkud commented Jan 23, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 23, 2023
bors bot pushed a commit that referenced this pull request Jan 23, 2023
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Eric Rodriguez <ericrboidi@gmail.com>
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: ADedecker <anatolededecker@gmail.com>
@bors
Copy link

bors bot commented Jan 23, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Feat: port Order.Filter.Basic [Merged by Bors] - Feat: port Order.Filter.Basic Jan 23, 2023
@bors bors bot closed this Jan 23, 2023
@bors bors bot deleted the port/Order.Filter.Basic branch January 23, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants