Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Algebra.IndicatorFunction #1752

Closed
wants to merge 12 commits into from

Conversation

LukasMias
Copy link
Collaborator

@LukasMias LukasMias commented Jan 21, 2023

Some mathport warning to pay attention to, and some proofs required some work explicitly using split_ifs which was not necessary in lean3, but otherwise straightforward.


Open in Gitpod

Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@LukasMias LukasMias added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 21, 2023
@LukasMias LukasMias added the help-wanted The author needs attention to resolve issues label Jan 21, 2023
@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jan 22, 2023
Mathlib/Algebra/IndicatorFunction.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/IndicatorFunction.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/IndicatorFunction.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/IndicatorFunction.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/IndicatorFunction.lean Outdated Show resolved Hide resolved
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 22, 2023
@bors
Copy link

bors bot commented Jan 22, 2023

Canceled.

bors bot pushed a commit that referenced this pull request Jan 22, 2023
Some mathport warning to pay attention to, and some proofs required some work explicitly using `split_ifs` which was not necessary in lean3, but otherwise straightforward.



Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jan 22, 2023
Some mathport warning to pay attention to, and some proofs required some work explicitly using `split_ifs` which was not necessary in lean3, but otherwise straightforward.



Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Jan 22, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.IndicatorFunction [Merged by Bors] - feat: port Algebra.IndicatorFunction Jan 22, 2023
@bors bors bot closed this Jan 22, 2023
@bors bors bot deleted the port/Algebra.IndicatorFunction branch January 22, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants