Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Feat: port Order.Filter.Bases #1791

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Feat: port Order.Filter.Bases #1791

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 23, 2023 •
edited

@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jan 23, 2023
@hrmacbeth hrmacbeth added the mathlib-port This is a port of a theory file from mathlib. label Jan 23, 2023
@urkud urkud mentioned this pull request Jan 24, 2023
Closed
1 task
@urkud urkud removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 24, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Jan 24, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@urkud urkud added the awaiting-review The author would like community review of the PR label Jan 24, 2023
@urkud
feat: port Order.Filter.Bases
5d5f472
@urkud
Initial file copy from mathport
17351a8
@urkud
automated fixes
617f4d2 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
jcommelin
jcommelin reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Bases.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 24, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 24, 2023
@urkud @jcommelin
Apply suggestions from code review
0243520 
Co-authored-by: Johan Commelin <johan@commelin.net>
@urkud
Copy link
Member Author

urkud commented Jan 24, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 24, 2023
bors bot pushed a commit that referenced this pull request Jan 24, 2023
@urkud
Feat: port Order.Filter.Bases (#1791)
218a453
@bors
Copy link

bors bot commented Jan 24, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Feat: port Order.Filter.Bases [Merged by Bors] - Feat: port Order.Filter.Bases Jan 24, 2023
@bors bors bot closed this Jan 24, 2023
@bors bors bot deleted the port/Order.Filter.Bases branch January 24, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @semorrison @jcommelin @hrmacbeth