Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Int.Log #1793

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Data.Int.Log #1793

wants to merge 6 commits into from

Conversation

LukasMias
Copy link
Collaborator

Open in Gitpod

@LukasMias
feat: port Data.Int.Log
5923e49
@LukasMias
Initial file copy from mathport
1a15f60
@LukasMias
automated fixes
84a9126 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@LukasMias LukasMias added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 23, 2023
@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 23, 2023
dupuisf
dupuisf reviewed Jan 24, 2023
View reviewed changes
Mathlib/Data/Int/Log.lean Outdated Show resolved Hide resolved
@dupuisf dupuisf added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 24, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 24, 2023
jcommelin
jcommelin reviewed Jan 24, 2023
View reviewed changes
Mathlib/Data/Int/Log.lean Outdated Show resolved Hide resolved
Mathlib/Data/Int/Log.lean Outdated Show resolved Hide resolved
Mathlib/Data/Int/Log.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 24, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 25, 2023
jcommelin
jcommelin approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 26, 2023
bors bot pushed a commit that referenced this pull request Jan 26, 2023
@LukasMias @Ruben-VandeVelde
feat: port Data.Int.Log (#1793)
fcb13d1 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 26, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Int.Log [Merged by Bors] - feat: port Data.Int.Log Jan 26, 2023
@bors bors bot closed this Jan 26, 2023
@bors bors bot deleted the port/Data.Int.Log branch January 26, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

@jcommelin jcommelin jcommelin approved these changes

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LukasMias @jcommelin @dupuisf @Ruben-VandeVelde @semorrison