Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port GroupTheory.Subgroup.Basic #1797

Closed
wants to merge 37 commits into from
Closed

[Merged by Bors] - feat: port GroupTheory.Subgroup.Basic #1797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
d17ef23
feat: port GroupTheory.Subgroup.Basic
Ruben-VandeVelde Jan 23, 2023
853951a
Initial file copy from mathport
Ruben-VandeVelde Jan 23, 2023
389e6a7
automated fixes
Ruben-VandeVelde Jan 23, 2023
b7d6afc
fixes
Ruben-VandeVelde Jan 23, 2023
0b6c65c
minifix
jcommelin Jan 24, 2023
b41d249
give hasZsmul and hasZpow congruent types
LukasMias Jan 24, 2023
7738cf5
small fixes
LukasMias Jan 24, 2023
0b9029c
Fixed comments and more.
qawbecrdtey Jan 25, 2023
7714bdf
More fixes.
qawbecrdtey Jan 25, 2023
4ba794d
further changes
LukasMias Jan 25, 2023
4d9390c
Fix `simps` projection
Vierkantor Jan 25, 2023
1008741
Use `simp` because the triangle is being obstinate again
Vierkantor Jan 25, 2023
b8ca528
Fix many of the typeclass issues: unbundled subclasses of `outParam` …
Vierkantor Jan 25, 2023
faf49b1
docstrings & minor fixes
LukasMias Jan 25, 2023
0bf9024
Merge branch 'port/GroupTheory.Subgroup.Basic' of github.com:leanprov…
LukasMias Jan 25, 2023
04f7e2b
long lines
LukasMias Jan 25, 2023
e3db17b
restore Subgroup.inclusion
LukasMias Jan 25, 2023
8923ba1
some redundant arguments
LukasMias Jan 25, 2023
6dbfc29
Merge remote-tracking branch 'origin/master' into port/GroupTheory.Su…
jcommelin Jan 25, 2023
e604b3b
minifix
jcommelin Jan 25, 2023
af42022
fix some errors
fpvandoorn Jan 25, 2023
7f152a1
change instance names
fpvandoorn Jan 25, 2023
600b4fa
fixes
jcommelin Jan 25, 2023
73e8a0f
fixes
jcommelin Jan 25, 2023
7e73377
fixes
jcommelin Jan 25, 2023
5f85930
fixes
jcommelin Jan 25, 2023
faba79d
fixes
jcommelin Jan 25, 2023
81ffc4e
auto: fix lints
jcommelin Jan 25, 2023
718cd39
auto: naming
jcommelin Jan 25, 2023
ec16bef
fix long lines
jcommelin Jan 25, 2023
db40de4
fix a lint
jcommelin Jan 25, 2023
0953d4e
fix remaining errors, add porting note
fpvandoorn Jan 25, 2023
651f7b8
Merge remote-tracking branch 'origin/port/GroupTheory.Subgroup.Basic'…
fpvandoorn Jan 25, 2023
74c8a00
lintfixes
fpvandoorn Jan 25, 2023
a59af1b
fix
fpvandoorn Jan 25, 2023
c12a653
Apply suggestions from code review
Ruben-VandeVelde Jan 26, 2023
7d4c9e7
to_additive some simps
ChrisHughes24 Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Mathlib.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,7 @@ import Mathlib.GroupTheory.GroupAction.Units
import Mathlib.GroupTheory.Perm.Basic
import Mathlib.GroupTheory.Perm.Support
import Mathlib.GroupTheory.Perm.ViaEmbedding
import Mathlib.GroupTheory.Subgroup.Basic
import Mathlib.GroupTheory.Submonoid.Basic
import Mathlib.GroupTheory.Submonoid.Center
import Mathlib.GroupTheory.Submonoid.Centralizer
Expand Down