Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Filter.Germ #1799

Closed
wants to merge 30 commits into from
Closed

[Merged by Bors] - feat: port Order.Filter.Germ #1799

wants to merge 30 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Jan 24, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jan 24, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 26, 2023
@nomeata
Copy link
Collaborator

nomeata commented Feb 3, 2023

I tried to help out, but gut stuck with to_additive not translating instPowGerm in instance monoid, and writing instance addMonoid by hand also failed because of coercions getting strangly in the way.

@Komyyy Komyyy added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Feb 15, 2023
dupuisf
dupuisf reviewed Feb 15, 2023
View reviewed changes
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
Komyyy and others added 7 commits February 15, 2023 10:51
@Komyyy @dupuisf
suggestion 1
6b6a896 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestion 2
e7e7b09 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestion 3
36a36c4 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestion 4
5c0bf03 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestion 5
7cb35c3 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestion 6
28175e3 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestion 7
60f82e8 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy Komyyy removed the awaiting-review The author would like community review of the PR label Feb 15, 2023
@Komyyy Komyyy added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 15, 2023
jcommelin
jcommelin reviewed Feb 15, 2023
View reviewed changes
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 15, 2023
@Komyyy Komyyy added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 15, 2023
jcommelin
jcommelin approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Order/Filter/Germ.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 15, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 15, 2023
@Komyyy @jcommelin
suggestion 3
f796f75 
Co-authored-by: Johan Commelin <johan@commelin.net>
@jcommelin
Copy link
Member

bors d=Komyyy

@bors
Copy link

bors bot commented Feb 15, 2023

✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Komyyy
Copy link
Collaborator

Komyyy commented Feb 15, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2023
@Ruben-VandeVelde @urkud
@nomeata @Komyyy
feat: port Order.Filter.Germ (#1799)
c8bff08 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 15, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Filter.Germ [Merged by Bors] - feat: port Order.Filter.Germ Feb 15, 2023
@bors bors bot closed this Feb 15, 2023
@bors bors bot deleted the port/Order.Filter.Germ branch February 15, 2023 08:22
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@Ruben-VandeVelde @urkud
@nomeata @Komyyy @mo271
feat: port Order.Filter.Germ (#1799)
0f123f7 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

@Komyyy Komyyy Komyyy left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Ruben-VandeVelde @nomeata @jcommelin @Komyyy @dupuisf @semorrison @urkud