Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Filter.Ultrafilter #1814

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: port Order.Filter.Ultrafilter #1814

wants to merge 10 commits into from

Conversation

ADedecker
Copy link
Member

Open in Gitpod

@ADedecker ADedecker added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 24, 2023
@urkud
Copy link
Member

urkud commented Jan 24, 2023

Did you use start_port.sh?

@ADedecker
Copy link
Member Author

I did, but I think the script failed at some point so not everything was done automatically (it was some awk error, I'll investigate a bit more this evening). Did that create a problem in any way?

@urkud urkud added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 24, 2023
jcommelin
jcommelin approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 24, 2023
bors bot pushed a commit that referenced this pull request Jan 24, 2023
@ADedecker @urkud
feat: port Order.Filter.Ultrafilter (#1814)
a923247 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Jan 24, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Filter.Ultrafilter [Merged by Bors] - feat: port Order.Filter.Ultrafilter Jan 24, 2023
@bors bors bot closed this Jan 24, 2023
@bors bors bot deleted the port/Order.Filter.Ultrafilter branch January 24, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ADedecker @urkud @jcommelin @semorrison