Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port Algebra.Quandle #1817

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat: Port Algebra.Quandle #1817

wants to merge 15 commits into from

Conversation

aricursion
Copy link
Collaborator

Open in Gitpod

@aricursion
feat: port Algebra.Quandle
43ff6f4
@aricursion
Initial file copy from mathport
624b397
@aricursion
automated fixes
01e7193 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@aricursion
intro
b7644c8
@aricursion
progress held up by group tactic
3e8c7b1
@aricursion aricursion added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 24, 2023
@aricursion aricursion added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 25, 2023
jcommelin
jcommelin reviewed Jan 25, 2023
View reviewed changes
Mathlib/Algebra/Quandle.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Quandle.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 25, 2023
@aricursion aricursion added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 25, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 25, 2023
@bors
Copy link

bors bot commented Jan 25, 2023

Canceled.

@aricursion
Copy link
Collaborator Author

@jcommelin sorry I didn't noitce you already started the merge. I realized there was one thing I thought should be changed, but I can change it back if it was better before

@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jan 26, 2023
@aricursion
feat: Port Algebra.Quandle (#1817)
e32b06c
@bors
Copy link

bors bot commented Jan 26, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port Algebra.Quandle [Merged by Bors] - feat: Port Algebra.Quandle Jan 26, 2023
@bors bors bot closed this Jan 26, 2023
@bors bors bot deleted the port/Algebra.Quandle branch January 26, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aricursion @jcommelin @ChrisHughes24