Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Fin.Tuple.Monotone #1827

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Data.Fin.Tuple.Monotone #1827

wants to merge 6 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Jan 25, 2023

Open in Gitpod

@int-y1
feat: port Data.Fin.Tuple.Monotone
c93a90b
@int-y1
Initial file copy from mathport
f91b289
@int-y1
automated fixes
ecfbe34 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 25, 2023
@int-y1 int-y1 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 25, 2023
jcommelin
jcommelin reviewed Jan 25, 2023
View reviewed changes
Mathlib/Data/Fin/Tuple/Monotone.lean Outdated
antitone_vecCons.2 ⟨ha, hf⟩
#align antitone.vec_cons Antitone.vecCons

-- Porting note: Commenting out this example, because it got stuck on proving `Monotone ![3]`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bit unfortunate, I guess. It would be good if we can get it to work.

jcommelin
jcommelin approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 25, 2023
bors bot pushed a commit that referenced this pull request Jan 25, 2023
@int-y1 @ChrisHughes24
feat: port Data.Fin.Tuple.Monotone (#1827)
fb29af6 
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Jan 25, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Fin.Tuple.Monotone [Merged by Bors] - feat: port Data.Fin.Tuple.Monotone Jan 25, 2023
@bors bors bot closed this Jan 25, 2023
@bors bors bot deleted the port/Data.Fin.Tuple.Monotone branch January 25, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@int-y1 @jcommelin @semorrison @ChrisHughes24