[Merged by Bors] - feat: port Data.Int.Parity #1836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneugster
added
WIP
joneugster
added
awaiting-review
jcommelin
approved these changes
Jan 26, 2023
Comment on lines
+77
to
+79
| -- Porting note: TODO. I'm struggling that `Even` uses `k + k` while Odd uses `2 * k`, | ||
| -- does this proof need golfing? | ||
| -- mathlib3 port: `simpa only [← two_mul, exists_or, ← Odd, ← Even] using even_or_odd n` |
There was a problem hiding this comment.
I think it's fine to keep both this comment and your proof. In the future, someone can revisit.
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
joneugster
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Int.modandInd.divwithInt.emodandInt.ediv. I think this is the right thing to do but not 100% sure.TODOineven_or_odd'. Either golf my new proof or remove the comment.