[Merged by Bors] - feat: port Topology.Bornology.Constructions #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-loreaux
added
blocked-by-other-PR
1 task
semorrison
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
semorrison
added
the
merge-conflict
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
j-loreaux
force-pushed
the
port/Topology.Bornology.Constructions
branch
from
953838e
to
7b8cef1
Compare
j-loreaux
removed
the
merge-conflict
|
✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with |
semorrison
added
delegated
and removed
awaiting-review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
porting notes: 1. at one point I had to explicit provide the bornology to `isBounded_univ`. This seems like a regression and should be investigated. - [x] depends on: #1822
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
porting notes: 1. In one place I had to provide explicitly the type of a hypothesis in a declaration which Lean 3 was able to infer from context. - [x] depends on: #1854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
porting notes:
isBounded_univ. This seems like a regression and should be investigated.