Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Algebra.Star.SelfAdjoint #1860

Closed
wants to merge 10 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Jan 26, 2023

See the Zulip thread for issues I encountered.


Open in Gitpod

Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@j-loreaux j-loreaux added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 26, 2023
@j-loreaux j-loreaux added the help-wanted The author needs attention to resolve issues label Jan 26, 2023
@LukasMias
Copy link
Collaborator

LukasMias commented Feb 4, 2023

I'd be guessing this is another lean4#2003 victim? I think we've resorted to the set_option maxHeartbeats workaround with those for now. It's not pretty, but hopefully will only be necessary for a short while longer.

@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Feb 5, 2023
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Algebra/Star/SelfAdjoint.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 5, 2023

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 5, 2023
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 6, 2023
bors bot pushed a commit that referenced this pull request Feb 6, 2023
See the [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Algebra.2EStar.2ESelfAdjoint.20!4.231860) for issues I encountered.



Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 6, 2023

Build failed (retrying...):

  • Build

bors bot pushed a commit that referenced this pull request Feb 6, 2023
See the [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Algebra.2EStar.2ESelfAdjoint.20!4.231860) for issues I encountered.



Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Star.SelfAdjoint [Merged by Bors] - feat: port Algebra.Star.SelfAdjoint Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
@bors bors bot deleted the port/Algebra.Star.SelfAdjoint branch February 6, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants