Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port GroupTheory.Subgroup.Finite #1864

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port GroupTheory.Subgroup.Finite #1864

wants to merge 9 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Jan 26, 2023 •
edited

Zulip thread for the issues I encountered.

Open in Gitpod

@j-loreaux
feat: port GroupTheory.Subgroup.Finite
95036d3
@j-loreaux
Initial file copy from mathport
6e3e3ba
@j-loreaux
automated fixes
acf7d2f 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@j-loreaux j-loreaux added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 26, 2023
@j-loreaux j-loreaux added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jan 26, 2023
@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jan 30, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 30, 2023
bors bot pushed a commit that referenced this pull request Jan 30, 2023
@j-loreaux
feat: port GroupTheory.Subgroup.Finite (#1864)
e6cffe7 
[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/.60simpNF.60.20problems) for the issues I encountered.
@bors
Copy link

bors bot commented Jan 30, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port GroupTheory.Subgroup.Finite [Merged by Bors] - feat: port GroupTheory.Subgroup.Finite Jan 30, 2023
@bors bors bot closed this Jan 30, 2023
@bors bors bot deleted the port/GroupTheory.Subgroup.Finite branch January 30, 2023 19:25
@rwbarton rwbarton mentioned this pull request Jan 30, 2023
Closed
1 task
bors bot pushed a commit that referenced this pull request Jan 30, 2023
@rwbarton
chore: fix naming in GroupTheory.Submonoid.Membership (#1950)
c73daed 
As seen in #1864, but I was too slow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j-loreaux @jcommelin