Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.LocallyFinite #1877

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Topology.LocallyFinite #1877

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 27, 2023

Open in Gitpod

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes mathlib-port This is a port of a theory file from mathlib. labels Jan 27, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 27, 2023
@urkud
feat: port Topology.LocallyFinite
00ad57f
@urkud
Initial file copy from mathport
6c7709a
@urkud
automated fixes
b68eddf 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Fix compile
dec27d3
@urkud
auto: naming
9383276
@urkud urkud force-pushed the port/Topology.LocallyFinite branch from 98e6584 to 9383276 Compare January 27, 2023 13:48
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jan 27, 2023
jcommelin
jcommelin approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 27, 2023
bors bot pushed a commit that referenced this pull request Jan 27, 2023
@urkud
feat: port Topology.LocallyFinite (#1877)
8b47448
@bors
Copy link

bors bot commented Jan 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.LocallyFinite [Merged by Bors] - feat: port Topology.LocallyFinite Jan 27, 2023
@bors bors bot closed this Jan 27, 2023
@bors bors bot deleted the port/Topology.LocallyFinite branch January 27, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @semorrison