[Merged by Bors] - feat: require @[simps!] if simps runs in expensive mode #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
awaiting-review
t-meta
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
semorrison
added
the
merge-conflict
|
I'm going to merge |
|
I merged |
urkud
removed
the
merge-conflict
|
maintainer merge |
|
I'm treating maintainer merge as bors d+ bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
* This does not change the behavior of `simps`, just raises a linter error if you run `simps` in a more expensive mode without writing `!`. * Fixed some incorrect occurrences of `to_additive, simps`. Will do that systematically in future PR. * Fix port of `OmegaCompletePartialOrder.ContinuousHom.ofMono` a bit Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
jcommelin
pushed a commit
that referenced
this pull request
Feb 7, 2023
* This does not change the behavior of `simps`, just raises a linter error if you run `simps` in a more expensive mode without writing `!`. * Fixed some incorrect occurrences of `to_additive, simps`. Will do that systematically in future PR. * Fix port of `OmegaCompletePartialOrder.ContinuousHom.ofMono` a bit Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simps, just raises a linter error if you runsimpsin a more expensive mode without writing!.to_additive, simps. Will do that systematically in future PR.OmegaCompletePartialOrder.ContinuousHom.ofMonoa bit