Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port/Data.Finsupp.Fin #1895

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: Port/Data.Finsupp.Fin #1895

wants to merge 8 commits into from

Conversation

arienmalec
Copy link
Collaborator

Port of data.finsupp.fin

Open in Gitpod

@arienmalec
feat: port Data.Finsupp.Fin
6dd82c4
@arienmalec
Initial file copy from mathport
d31aef1
@arienmalec
automated fixes
1baa2d5 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@arienmalec
explicit naming for ext
d78d652
@arienmalec arienmalec added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 27, 2023
@arienmalec arienmalec added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 27, 2023
jcommelin
jcommelin approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 28, 2023
bors bot pushed a commit that referenced this pull request Jan 28, 2023
@arienmalec
feat: Port/Data.Finsupp.Fin (#1895)
4c0d5df 
Port of data.finsupp.fin
@bors
Copy link

bors bot commented Jan 28, 2023

Build failed (retrying...):

  • Build

bors bot pushed a commit that referenced this pull request Jan 28, 2023
@arienmalec
feat: Port/Data.Finsupp.Fin (#1895)
2c6b1ac 
Port of data.finsupp.fin
@bors
Copy link

bors bot commented Jan 28, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port/Data.Finsupp.Fin [Merged by Bors] - feat: Port/Data.Finsupp.Fin Jan 28, 2023
@bors bors bot closed this Jan 28, 2023
@bors bors bot deleted the port/Data.Finsupp.Fin branch January 28, 2023 07:32
@dwrensha dwrensha mentioned this pull request Feb 14, 2023
Closed
bors bot pushed a commit that referenced this pull request Feb 15, 2023
@dwrensha
fix: use rfl instead of namedPattern rfl rfl rfl (#2276)
c2003aa 
`library_search` currently has a bug where it sometimes unnecessarily wraps its output in `namedPattern`.

This PR removes a usage of `namedPattern` that got introduced in #1895, presumably due to the `library_search` bug.
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@dwrensha @mo271
fix: use rfl instead of namedPattern rfl rfl rfl (#2276)
c43637d 
`library_search` currently has a bug where it sometimes unnecessarily wraps its output in `namedPattern`.

This PR removes a usage of `namedPattern` that got introduced in #1895, presumably due to the `library_search` bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arienmalec @jcommelin @semorrison