Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.SubsetProperties #1913

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Topology.SubsetProperties #1913

wants to merge 9 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 28, 2023

Open in Gitpod

@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jan 29, 2023
@urkud urkud force-pushed the port/Topology.SubsetProperties branch from 8af08fc to c3f40cf Compare February 1, 2023 11:41
@urkud
feat: port Topology.SubsetProperties
63f8614
@urkud
Initial file copy from mathport
f9234e8
@urkud
automated fixes
c6e1185 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud urkud force-pushed the port/Topology.SubsetProperties branch from c3f40cf to 77768cc Compare February 1, 2023 11:48
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Feb 1, 2023
@urkud urkud force-pushed the port/Topology.SubsetProperties branch from 5f27ed6 to 1a9865a Compare February 1, 2023 12:08
jcommelin
jcommelin reviewed Feb 1, 2023
View reviewed changes
Mathlib/Topology/SubsetProperties.lean Outdated Show resolved Hide resolved
Mathlib/Topology/SubsetProperties.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 1, 2023
bors bot pushed a commit that referenced this pull request Feb 1, 2023
@urkud @jcommelin
feat: port Topology.SubsetProperties (#1913)
2d0727f 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 1, 2023

Build failed:

  • Build

@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Feb 1, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 1, 2023
@urkud @jcommelin
feat: port Topology.SubsetProperties (#1913)
da33096 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 1, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.SubsetProperties [Merged by Bors] - feat: port Topology.SubsetProperties Feb 1, 2023
@bors bors bot closed this Feb 1, 2023
@bors bors bot deleted the port/Topology.SubsetProperties branch February 1, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @semorrison