Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Finsupp.Indicator #1916

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port Data.Finsupp.Indicator #1916

wants to merge 4 commits into from

Conversation

LukasMias
Copy link
Collaborator

Open in Gitpod

@LukasMias
feat: port Data.Finsupp.Indicator
b2b353a
@LukasMias
Initial file copy from mathport
a35d3a3
@LukasMias
automated fixes
eea88e2 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@LukasMias LukasMias added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 28, 2023
@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 28, 2023
dupuisf
dupuisf reviewed Jan 29, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 29, 2023
bors bot pushed a commit that referenced this pull request Jan 29, 2023
@LukasMias
feat: port Data.Finsupp.Indicator (#1916)
8f7e722
@bors
Copy link

bors bot commented Jan 29, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Finsupp.Indicator [Merged by Bors] - feat: port Data.Finsupp.Indicator Jan 29, 2023
@bors bors bot closed this Jan 29, 2023
@bors bors bot deleted the port/Data.Finsupp.Indicator branch January 29, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasMias @dupuisf @semorrison