Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port Algebra.IsPrimePow #1925

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: Port Algebra.IsPrimePow #1925

wants to merge 5 commits into from

Conversation

casavaca
Copy link
Collaborator

Open in Gitpod

@casavaca
feat: port Algebra.IsPrimePow
06fcdf2
@casavaca
Initial file copy from mathport
bdfb10d
@casavaca
automated fixes
62a6e46 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@casavaca
Small fixes.
83e90fe
@casavaca casavaca added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 29, 2023
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Jan 29, 2023
View reviewed changes
Mathlib/Algebra/IsPrimePow.lean Outdated
simp only [pow_zero, ne_eq] at hm₁
#align is_prime_pow.dvd IsPrimePow.dvd

theorem Nat.disjoint_divisors_filter_prime_pow {a b : ℕ} (hab : a.coprime b) :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is better as

Suggested change
theorem Nat.disjoint_divisors_filter_prime_pow {a b : ℕ} (hab : a.coprime b) :
theorem Nat.disjoint_divisors_filter_isPrimePow {a b : ℕ} (hab : a.coprime b) :

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

dupuisf
dupuisf reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 30, 2023
bors bot pushed a commit that referenced this pull request Jan 30, 2023
@casavaca
feat: Port Algebra.IsPrimePow (#1925)
d473258
@bors
Copy link

bors bot commented Jan 30, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port Algebra.IsPrimePow [Merged by Bors] - feat: Port Algebra.IsPrimePow Jan 30, 2023
@bors bors bot closed this Jan 30, 2023
@bors bors bot deleted the port/Algebra.IsPrimePow branch January 30, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@casavaca @dupuisf @Ruben-VandeVelde @semorrison