Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Combinatorics.Colex #1926

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Combinatorics.Colex #1926

wants to merge 11 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jan 29, 2023

Open in Gitpod

@mo271
feat: port Combinatorics.Colex
edd0647
@mo271
Initial file copy from mathport
37dda8c
@mo271
automated fixes
f6d8a37 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mo271
starting
4ceaaae
@mo271 mo271 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 29, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Jan 29, 2023

Currently trying to get LinearOrder (Finset.Colex α) to work...

@mo271 mo271 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jan 29, 2023
@Komyyy Komyyy added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Feb 4, 2023
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 4, 2023
@Komyyy Komyyy added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 4, 2023
jcommelin
jcommelin approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 4, 2023
bors bot pushed a commit that referenced this pull request Feb 4, 2023
@mo271 @Komyyy
feat: port Combinatorics.Colex (#1926)
acdd22b 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@bors
Copy link

bors bot commented Feb 4, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Combinatorics.Colex [Merged by Bors] - feat: port Combinatorics.Colex Feb 4, 2023
@bors bors bot closed this Feb 4, 2023
@bors bors bot deleted the port/Combinatorics.Colex branch February 4, 2023 10:37
semorrison added a commit that referenced this pull request Oct 22, 2023
@semorrison
remove all porting notes tagged #1926
1406284
This was referenced Jan 4, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mo271 @jcommelin @semorrison @Komyyy