Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.BigOperators.Associated #1943

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Algebra.BigOperators.Associated #1943

wants to merge 6 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Jan 30, 2023

Open in Gitpod

@xroblot
feat: port Algebra.BigOperators.Associated
b0543c8
@xroblot
Initial file copy from mathport
e877cc4
@xroblot
automated fixes
f0c26d8 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@xroblot xroblot added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 30, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 31, 2023
@xroblot
Copy link
Collaborator Author

xroblot commented Jan 31, 2023

@Ruben-VandeVelde, I wanted to see what the resolution of https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/count_eq_card_filter_eq/near/324876075 would be before finishing this PR... Although it looks like it will probably be the status quo.

jcommelin
jcommelin approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this. We can refactor later if the definition of Multiset.count changes.

bors d+

@bors
Copy link

bors bot commented Jan 31, 2023

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 31, 2023
@xroblot
Copy link
Collaborator Author

xroblot commented Jan 31, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 31, 2023
@xroblot @Ruben-VandeVelde
feat: port Algebra.BigOperators.Associated (#1943)
9c6f795 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 31, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.BigOperators.Associated [Merged by Bors] - feat: port Algebra.BigOperators.Associated Jan 31, 2023
@bors bors bot closed this Jan 31, 2023
@bors bors bot deleted the port/Algebra.BigOperators.Associated branch January 31, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xroblot @jcommelin @semorrison @Ruben-VandeVelde