Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: misaligned to_additive in Data/Set/Pointwise/ListOfFn #1946

Closed
wants to merge 2 commits into from

Conversation

LukasMias
Copy link
Collaborator

@LukasMias LukasMias commented Jan 30, 2023

A misaligned to_additive causes some proofs to fail in #1911. No backport needed, the misalign happened due to a mathlib4 exclusive mistake as I understand.


Open in Gitpod

@LukasMias LukasMias added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 30, 2023
@LukasMias LukasMias changed the title fix: misaligned to_additive fix: misaligned to_additive in Data/Set/Pointwise/ListOfFn Jan 30, 2023
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jan 30, 2023
bors bot pushed a commit that referenced this pull request Jan 30, 2023
A misaligned `to_additive` causes some proofs to fail in #1911. No backport needed, the misalign happened due to a mathlib4 exclusive mistake as I understand.
@bors
Copy link

bors bot commented Jan 30, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: misaligned to_additive in Data/Set/Pointwise/ListOfFn [Merged by Bors] - fix: misaligned to_additive in Data/Set/Pointwise/ListOfFn Jan 30, 2023
@bors bors bot closed this Jan 30, 2023
@bors bors bot deleted the list_of_fn_nsmul branch January 30, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants