[Merged by Bors] - feat: Add instance of Infinite String #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
reviewed
Jan 31, 2023
Mathlib/Data/Fintype/Card.lean
Outdated
| Infinite.of_surjective String.length <| by | ||
| intro n | ||
| exists (String.replicate n 'x') | ||
| exact String.length_replicate n 'x' |
There was a problem hiding this comment.
I think the proof is even shorter if you move it down a few lines and use String.data instead
There was a problem hiding this comment.
I've now changed the proof so it uses the injectivity of String.mk. I suspect that said injectivity could be proven more concisely, do you have any suggestions in that regard?
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
This proves that the `String` type is infinite.
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
joelriou
pushed a commit
that referenced
this pull request
Mar 30, 2023
This proves that the `String` type is infinite.
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
This proves that the `String` type is infinite.
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
This proves that the `String` type is infinite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proves that the
Stringtype is infinite.