Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.UpperLower.Basic #1978

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Order.UpperLower.Basic #1978

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 1, 2023

Open in Gitpod

@urkud
feat: port Order.UpperLower.Basic
3598a57
@urkud
Initial file copy from mathport
181af37
@urkud
automated fixes
f8a132b 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Fix compile
8f7a4e4
@urkud
auto: naming
912ae46
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Feb 1, 2023
jcommelin
jcommelin approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 1, 2023
bors bot pushed a commit that referenced this pull request Feb 1, 2023
@urkud
feat: port Order.UpperLower.Basic (#1978)
d869cdc
@bors
Copy link

bors bot commented Feb 1, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.UpperLower.Basic [Merged by Bors] - feat: port Order.UpperLower.Basic Feb 1, 2023
@bors bors bot closed this Feb 1, 2023
@bors bors bot deleted the port/Order.UpperLower.Basic branch February 1, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @semorrison