Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Ideal #1985

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat: port Order.Ideal #1985

wants to merge 14 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Feb 1, 2023

Open in Gitpod

@int-y1
feat: port Order.Ideal
abc95ae
@int-y1
Initial file copy from mathport
12427ff
@int-y1
automated fixes
d88a5b1 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 1, 2023
@int-y1 int-y1 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 2, 2023
jcommelin
jcommelin reviewed Feb 2, 2023
View reviewed changes
Mathlib/Order/Ideal.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 2, 2023
bors bot pushed a commit that referenced this pull request Feb 2, 2023
@int-y1 @jcommelin
feat: port Order.Ideal (#1985)
a4cb396 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 2, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Ideal [Merged by Bors] - feat: port Order.Ideal Feb 2, 2023
@bors bors bot closed this Feb 2, 2023
@bors bors bot deleted the port/Order.Ideal branch February 2, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@int-y1 @jcommelin