Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Finsupp.Multiset #1988

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Data.Finsupp.Multiset #1988

wants to merge 7 commits into from

Conversation

LukasMias
Copy link
Collaborator

@LukasMias LukasMias commented Feb 1, 2023 •
edited

Some proofs needed rewriting because or different unfolding behaviour of Equivs and toFuns, but in the end it was not too bad. Revisiting Hom/Equiv/Basic might be valuable at some point

Open in Gitpod

@LukasMias
feat: port Data.Finsupp.Multiset
5e63b97
@LukasMias
Initial file copy from mathport
e5c90b2
@LukasMias
automated fixes
0870838 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@LukasMias LukasMias added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 1, 2023
@LukasMias LukasMias added the help-wanted The author needs attention to resolve issues label Feb 1, 2023
@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Feb 3, 2023
@jcommelin
Copy link
Member

@LukasMias should the top comment be updated? It becomes the commit comment after merging...

@LukasMias
Copy link
Collaborator Author

LukasMias commented Feb 3, 2023 •
edited

@LukasMias should the top comment be updated? It becomes the commit comment after merging...

Whoops, forgot about that one. Yeah, things were not quite as grim as I initially thought. Some rfl proofs needed to be explicitly spelled out. Thanks, gave it a rewrite!

jcommelin
jcommelin approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 3, 2023
bors bot pushed a commit that referenced this pull request Feb 3, 2023
@LukasMias
feat: port Data.Finsupp.Multiset (#1988)
88a42cb 
Some proofs needed rewriting because or different unfolding behaviour of `Equiv`s and `toFun`s, but in the end it was not too bad. Revisiting Hom/Equiv/Basic might be valuable at some point
@bors
Copy link

bors bot commented Feb 3, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Finsupp.Multiset [Merged by Bors] - feat: port Data.Finsupp.Multiset Feb 3, 2023
@bors bors bot closed this Feb 3, 2023
@bors bors bot deleted the port/Data.Finsupp.Multiset branch February 3, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasMias @jcommelin @semorrison