[Merged by Bors] - feat: Port/Data.Finsupp.ToDfinsupp #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
arienmalec
added
WIP
jcommelin
reviewed
Feb 3, 2023
Mathlib/Data/Finsupp/ToDfinsupp.lean
Outdated
Comment on lines
296
to
302
| toFun f := | ||
| ⟨split f, | ||
| Trunc.mk | ||
| ⟨(splitSupport f : Finset ι).val, fun i => | ||
| by | ||
| rw [← Finset.mem_def, mem_splitSupport_iff_nonzero] | ||
| exact (em _).symm⟩⟩ |
|
bors d+ |
|
✌️ arienmalec can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
port of data.finsup.to_dfinsupp includes naming of instances in `Data.Finsupp.Defs` Had to unroll the instance defs for `sigmaFinsuppLequivDfinsupp` (duplicating defs) to address a timeout issue. Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of data.finsup.to_dfinsupp
includes naming of instances in
Data.Finsupp.DefsHad to unroll the instance defs for
sigmaFinsuppLequivDfinsupp(duplicating defs) to address a timeout issue.