Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.UniformSpace.UniformEmbedding #2038

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Topology.UniformSpace.UniformEmbedding #2038

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 3, 2023

Open in Gitpod

@urkud urkud force-pushed the port/Topology.UniformSpace.UniformEmbedding branch from bb4a42e to 7f0f832 Compare February 3, 2023 09:54
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 3, 2023
@urkud
feat: port Topology.UniformSpace.UniformEmbedding
702ffb4
@urkud
Initial file copy from mathport
14360b6
@urkud
automated fixes
57ab726 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Partially fix
27cb6cf
@urkud
Fix golf
9ace615
@urkud urkud force-pushed the port/Topology.UniformSpace.UniformEmbedding branch from 7f0f832 to 9ace615 Compare February 3, 2023 22:16
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Feb 3, 2023
dupuisf
dupuisf reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Topology/UniformSpace/UniformEmbedding.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/UniformEmbedding.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 3, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 3, 2023
@urkud @dupuisf
Apply suggestions from code review
0e80221 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
jcommelin
jcommelin approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added the ready-to-merge This PR has been sent to bors. label Feb 4, 2023
bors bot pushed a commit that referenced this pull request Feb 4, 2023
@urkud
feat: port Topology.UniformSpace.UniformEmbedding (#2038)
3af293c
@bors
Copy link

bors bot commented Feb 4, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.UniformSpace.UniformEmbedding [Merged by Bors] - feat: port Topology.UniformSpace.UniformEmbedding Feb 4, 2023
@bors bors bot closed this Feb 4, 2023
@bors bors bot deleted the port/Topology.UniformSpace.UniformEmbedding branch February 4, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @jcommelin @dupuisf @semorrison