[Merged by Bors] - feat: simps uses fields of parent structures #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
awaiting-review
t-meta
1 task
gebner
reviewed
Feb 3, 2023
fpvandoorn
added
awaiting-author
|
I separated out roughly the definitions you wrote. Thanks for that, they were much nicer than the versions I had myself earlier.
|
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
fpvandoorn
added
awaiting-review
and removed
awaiting-author
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
|
It seems like an improvement to me, and given there haven't been any more comments in the last few weeks: bors d+ |
|
✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with |
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
* `initialize_simps_projections` now by default generates all projections of all parent structures, and doesn't generate the projections to those parent structures. * You can also rename a nested projection directly, without having to specify intermediate parent structures * Added the option to turn the default behavior off (done in e.g. `TwoPointed`) Internal changes: * Move most declarations to the Simps namespace, and shorten their names * Restructure `ParsedProjectionData` to avoid the bug [reported here](https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/allocation.20crash.3F) (and to another bug where it seemed that the wrong data was inserted in `ParsedProjectionData`, but it was hard to minimize because of all the crashes). If we manage to fix the bug in that Zulip thread, I'll see if I can track down the other bug in commit 9745428 Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialize_simps_projectionsnow by default generates all projections of all parent structures, and doesn't generate the projections to those parent structures.TwoPointed)Internal changes:
ParsedProjectionDatato avoid the bug reported here (and to another bug where it seemed that the wrong data was inserted inParsedProjectionData, but it was hard to minimize because of all the crashes). If we manage to fix the bug in that Zulip thread, I'll see if I can track down the other bug in commit 9745428This likely conflicts with future PRs, so please delegate instead of merge