Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - [Merged by Bors] - chore: forward-port leanprover-community/mathlib#17895 #2046

Closed
wants to merge 7 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Feb 3, 2023

It looks like one of the files in leanprover-community/mathlib#17895 was caught in a race condition and missed the other forward-port.


See https://leanprover-community.github.io/mathlib-port-status/out-of-sync to compare the diff

Open in Gitpod

This is currently failing due to what looks like a to_additive bug.

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI labels Feb 3, 2023
@eric-wieser eric-wieser added help-wanted The author needs attention to resolve issues mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Feb 3, 2023
@eric-wieser eric-wieser removed the help-wanted The author needs attention to resolve issues label Feb 27, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR to Mathlib and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Feb 27, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 26, 2023
bors bot pushed a commit that referenced this pull request Mar 26, 2023
It looks like one of the files in leanprover-community/mathlib#17895 was caught in a race condition and missed the other forward-port.
@bors
Copy link

bors bot commented Mar 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: forward-port leanprover-community/mathlib#17895 [Merged by Bors] - chore: forward-port leanprover-community/mathlib#17895 Mar 27, 2023
@bors bors bot closed this Mar 27, 2023
@bors bors bot deleted the eric-wieser/port-17895 branch March 27, 2023 00:51
@bors
Copy link

bors bot commented Mar 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title [Merged by Bors] - chore: forward-port leanprover-community/mathlib#17895 [Merged by Bors] - [Merged by Bors] - chore: forward-port leanprover-community/mathlib#17895 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
No open projects
Status: SHA added
Development

Successfully merging this pull request may close these issues.

None yet

3 participants