Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Partition.Equipartition #2058

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Order.Partition.Equipartition #2058

wants to merge 8 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Feb 4, 2023

Open in Gitpod

@mo271
feat: port Order.Partition.Equipartition
b9b6fc6
@mo271
Initial file copy from mathport
0b37553
@mo271
automated fixes
ed88fd7 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mo271
first pass
efb1d82
@mo271 mo271 changed the title Port/order.partition.equipartition feat: port Order.Partition.Equipartition Feb 4, 2023
@mo271 mo271 added mathlib-port This is a port of a theory file from mathlib. awaiting-review The author would like community review of the PR labels Feb 4, 2023
dupuisf
dupuisf reviewed Feb 5, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few naming changes, ortherwise LGTM!

bors d+

Mathlib/Order/Partition/Equipartition.lean Outdated Show resolved Hide resolved
Mathlib/Order/Partition/Equipartition.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 5, 2023

✌️ mo271 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 5, 2023
mo271 and others added 2 commits February 5, 2023 13:13
@mo271 @dupuisf
Update Mathlib/Order/Partition/Equipartition.lean
26697d4 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@mo271 @dupuisf
Update Mathlib/Order/Partition/Equipartition.lean
4d43454 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@mo271
Copy link
Collaborator Author

mo271 commented Feb 5, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 5, 2023
@mo271
feat: port Order.Partition.Equipartition (#2058)
b706360 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Feb 5, 2023

Build failed:

  • Build

@mo271
Copy link
Collaborator Author

mo271 commented Feb 5, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 5, 2023
@mo271
feat: port Order.Partition.Equipartition (#2058)
81507de 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Feb 5, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Partition.Equipartition [Merged by Bors] - feat: port Order.Partition.Equipartition Feb 5, 2023
@bors bors bot closed this Feb 5, 2023
@bors bors bot deleted the port/Order.Partition.Equipartition branch February 5, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @dupuisf @semorrison