Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: AddMonoidWithOne, AddGroupWithOne #206

Closed
wants to merge 2 commits into from

Conversation

gebner
Copy link
Member

@gebner gebner commented Feb 22, 2022

Counterpart to leanprover-community/mathlib#12182. Solves the performance issues with polymorphic numerals from #177, as well as the diamonds with Nat.

A noteworthy feature is that after importing mathlib, the coercion ℕ → ℤ changes from Int.ofNat to Nat.cast.

@gebner
Copy link
Member Author

gebner commented Feb 23, 2022

bors merge

bors bot pushed a commit that referenced this pull request Feb 23, 2022
Counterpart to leanprover-community/mathlib#12182.  Solves the performance issues with polymorphic numerals from #177, as well as the diamonds with Nat.

A noteworthy feature is that after importing mathlib, the coercion `ℕ → ℤ` changes from `Int.ofNat` to `Nat.cast`.
@bors
Copy link

bors bot commented Feb 23, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: AddMonoidWithOne, AddGroupWithOne [Merged by Bors] - feat: AddMonoidWithOne, AddGroupWithOne Feb 23, 2022
@bors bors bot closed this Feb 23, 2022
@bors bors bot deleted the add_monoid_with_one branch February 23, 2022 09:07
mathlib-bors bot pushed a commit that referenced this pull request Apr 18, 2024
`Int.cast_Nat_cast` dates back to the ad-hoc port, in #206.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
`Int.cast_Nat_cast` dates back to the ad-hoc port, in #206.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
`Int.cast_Nat_cast` dates back to the ad-hoc port, in #206.
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
`Int.cast_Nat_cast` dates back to the ad-hoc port, in #206.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant