Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Data.Setoid.Partition #2066

Closed
wants to merge 13 commits into from

Conversation

arienmalec
Copy link
Collaborator

@arienmalec arienmalec commented Feb 5, 2023

port of data.setoid.partition

mostly simple fixes. Commented out simp of mem_index to address simpNF


Open in Gitpod

@arienmalec arienmalec added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Feb 5, 2023
@arienmalec arienmalec added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Feb 5, 2023
@arienmalec arienmalec added help-wanted The author needs attention to resolve issues and removed awaiting-review The author would like community review of the PR labels Feb 5, 2023
@arienmalec
Copy link
Collaborator Author

stuck on IndexedPartition.mk'.index

@arienmalec arienmalec added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Feb 5, 2023
@mo271 mo271 changed the title feat: Port/Data.Setoid.Partition feat: port Data.Setoid.Partition Feb 5, 2023
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Comment on lines +47 to +48
/- ./././Mathport/Syntax/Translate/Basic.lean:628:2:
-- warning: expanding binder collection (b «expr ∈ » c) -/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/- ./././Mathport/Syntax/Translate/Basic.lean:628:2:
-- warning: expanding binder collection (b «expr ∈ » c) -/

and the other ones below

@bors
Copy link

bors bot commented Feb 6, 2023

✌️ arienmalec can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 6, 2023
@arienmalec
Copy link
Collaborator Author

arienmalec commented Feb 6, 2023 via email

bors bot pushed a commit that referenced this pull request Feb 6, 2023
port of data.setoid.partition

mostly simple fixes. Commented out `simp` of `mem_index` to address `simpNF`
@bors
Copy link

bors bot commented Feb 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Setoid.Partition [Merged by Bors] - feat: port Data.Setoid.Partition Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
@bors bors bot deleted the port/Data.Setoid.Partition branch February 6, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants