Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Order.Priestley #2070

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Topology.Order.Priestley #2070

wants to merge 5 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Feb 5, 2023

Open in Gitpod

@int-y1
feat: port Topology.Order.Priestley
8aed6bc
@int-y1
Initial file copy from mathport
b518d68
@int-y1
automated fixes
68c15b0 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@int-y1 int-y1 added the mathlib-port This is a port of a theory file from mathlib. label Feb 5, 2023
@int-y1 int-y1 added the awaiting-review The author would like community review of the PR label Feb 5, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 5, 2023
jcommelin
jcommelin approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@bors
Copy link

bors bot commented Feb 6, 2023

👎 Rejected by label

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 6, 2023
@jcommelin jcommelin removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 6, 2023
@jcommelin
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@int-y1 @jcommelin
feat: port Topology.Order.Priestley (#2070)
1bd8f67 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 6, 2023

Build failed (retrying...):

  • Build

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@int-y1 @jcommelin
feat: port Topology.Order.Priestley (#2070)
f60e07f 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 6, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@int-y1 @jcommelin
feat: port Topology.Order.Priestley (#2070)
b5813cc 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Order.Priestley [Merged by Bors] - feat: port Topology.Order.Priestley Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
@bors bors bot deleted the port/Topology.Order.Priestley branch February 6, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@int-y1 @jcommelin @semorrison