Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.LiminfLimsup #2078

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat: port Order.LiminfLimsup #2078

wants to merge 15 commits into from

Conversation

LukasMias
Copy link
Collaborator

@LukasMias LukasMias commented Feb 5, 2023 •
edited

Most notable parts of this file:

  • Needed to translate isBoundedDefault macro to lean4, very easy
  • Had to replace e with FunLike.coe e in a theorem statement to prevent strange coercion behaviour for Equivs.

Open in Gitpod

@LukasMias
feat: port Order.LiminfLimsup
9bd9104
@LukasMias
Initial file copy from mathport
ea4d5e1
@LukasMias
automated fixes
0cb488b 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@LukasMias
first fixes
f3fed03
@LukasMias
first fixes
366b894
@LukasMias LukasMias added help-wanted The author needs attention to resolve issues WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 5, 2023
@LukasMias LukasMias changed the title feat: port Order/LiminfLimsup feat: port Order.LiminfLimsup Feb 5, 2023
@semorrison semorrison added the blocked-by-math-PR This PR depends on another PR to Mathlib label Feb 5, 2023
@semorrison semorrison removed the blocked-by-math-PR This PR depends on another PR to Mathlib label Feb 6, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 6, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 7, 2023
@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Feb 7, 2023
jcommelin
jcommelin reviewed Feb 7, 2023
View reviewed changes
Mathlib/Order/LiminfLimsup.lean Outdated Show resolved Hide resolved
Mathlib/Order/LiminfLimsup.lean Outdated Show resolved Hide resolved
Mathlib/Order/LiminfLimsup.lean Outdated Show resolved Hide resolved
Mathlib/Order/LiminfLimsup.lean Outdated Show resolved Hide resolved
Mathlib/Order/LiminfLimsup.lean Outdated Show resolved Hide resolved
Mathlib/Order/LiminfLimsup.lean Outdated Show resolved Hide resolved
Mathlib/Order/LiminfLimsup.lean Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 7, 2023
@LukasMias LukasMias added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 7, 2023
jcommelin
jcommelin approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 7, 2023
bors bot pushed a commit that referenced this pull request Feb 7, 2023
@LukasMias
feat: port Order.LiminfLimsup (#2078)
7a7c6e0 
Most notable parts of this file:
- Needed to translate `isBoundedDefault` macro to lean4, very easy
- Had to replace `e` with `FunLike.coe e` in a theorem statement to prevent strange coercion behaviour for Equivs.
@bors
Copy link

bors bot commented Feb 7, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.LiminfLimsup [Merged by Bors] - feat: port Order.LiminfLimsup Feb 7, 2023
@bors bors bot closed this Feb 7, 2023
@bors bors bot deleted the port/Order.LiminfLimsup branch February 7, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasMias @semorrison @jcommelin