Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - docs: Fix copy’n'pasta in Mathlib/Algebra/Module/LinearMap.lean #2082

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - docs: Fix copy’n'pasta in Mathlib/Algebra/Module/LinearMap.lean #2082

wants to merge 2 commits into from

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Feb 5, 2023

@nomeata nomeata marked this pull request as ready for review February 5, 2023 17:50
@nomeata nomeata added documentation Improvements or additions to documentation awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Feb 5, 2023
@eric-wieser eric-wieser changed the title [docs] Fix copy’n'pasta in Mathlib/Algebra/Module/LinearMap.lean docs: Fix copy’n'pasta in Mathlib/Algebra/Module/LinearMap.lean Feb 5, 2023
@eric-wieser
Copy link
Member

Let's wait for the mathlib 3 PR to go through, so that we can update the sha at the same time

@nomeata
Copy link
Collaborator Author

nomeata commented Feb 5, 2023

Thanks, makes sense (first such PR by me)

eric-wieser
eric-wieser approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked against https://leanprover-community.github.io/mathlib-port-status/out-of-sync.html, there were no other changes that slipped in between the ported version and this revision

bors merge

Thanks!

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 6, 2023
bors bot pushed a commit that referenced this pull request Feb 6, 2023
@nomeata
docs: Fix copy’n'pasta in Mathlib/Algebra/Module/LinearMap.lean (#2082)
633d7a1
@bors
Copy link

bors bot commented Feb 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title docs: Fix copy’n'pasta in Mathlib/Algebra/Module/LinearMap.lean [Merged by Bors] - docs: Fix copy’n'pasta in Mathlib/Algebra/Module/LinearMap.lean Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
@bors bors bot deleted the joachim/linear-maps-comment branch February 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nomeata @eric-wieser @semorrison