Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: space after separator #210

Closed
wants to merge 1 commit into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Feb 22, 2022

@gebner
Copy link
Member

gebner commented Feb 22, 2022

bors r+

@gebner
Copy link
Member

gebner commented Feb 22, 2022

I think we had a similar problem for binder notation, and there I added the space in mathport (addSpaceBeforeBinders). It shouldn't make a difference though, the notation3 command is temporary after all.

@bors
Copy link

bors bot commented Feb 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: space after separator [Merged by Bors] - fix: space after separator Feb 22, 2022
@bors bors bot closed this Feb 22, 2022
@bors bors bot deleted the notation3_space branch February 22, 2022 16:52
@digama0
Copy link
Member Author

digama0 commented Feb 22, 2022

It shouldn't make a difference though, the notation3 command is temporary after all.

I'm not so sure about that. I mean yes, the name notation3 is terrible, but it does things in one line that you currently can't do with lean 4 builtin stuff. (If you could, I would have used that in mathport instead of making a custom notation.) You need to set up syntax, elab and delab, and for binders and fold notations this currently involves writing a small program, which seems like a bad tradeoff for people introducing e.g. vec_notation or big_operators.

@gebner
Copy link
Member

gebner commented Feb 22, 2022

Completely agreed that we need a higher-level API to declare custom binders, etc. I'm just not convinced that the Lean 3 notation command is the ideal API to base this on, as it is famously hard to learn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants