Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Computability.TuringMachine #2125

Closed
wants to merge 50 commits into from
Closed

[Merged by Bors] - feat: port Computability.TuringMachine #2125

wants to merge 50 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Feb 7, 2023 •
edited

This file uses local notation to make the types more concise. (Very few other files used local notation in this way.)

Open in Gitpod

@int-y1
feat: port Computability.TuringMachine
1f7a455
@int-y1
Initial file copy from mathport
26cc276
@int-y1
automated fixes
0307697 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 7, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Feb 8, 2023 •
edited

  • There's 1 wlog in this file.
  • There are lots of red errors remaining.

@int-y1 int-y1 added the help-wanted The author needs attention to resolve issues label Feb 11, 2023
@Komyyy Komyyy added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Feb 14, 2023
dupuisf
dupuisf reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pretty much only have cosmetic remarks.

bors d+

Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
Mathlib/Computability/TuringMachine.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 14, 2023

✌️ int-y1 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 14, 2023
Komyyy and others added 11 commits February 15, 2023 08:59
@Komyyy @dupuisf
suggestions 1
ebeaa8b 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestions 2
fee7aab 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestions 3
d646137 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestions 4
1755e91 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestions 5
a59375e 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestions 6
4fde360 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestions 7
ee5d98d 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestions 8
57ef9a0 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestions 9
0b4d6f3 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Komyyy @dupuisf
suggestions 10
ffc2e36 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@int-y1
remove other similar comments
a72d349
@int-y1
Copy link
Collaborator Author

int-y1 commented Feb 15, 2023

🎉
bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2023
@int-y1
feat: port Computability.TuringMachine (#2125)
16ba027
@bors
Copy link

bors bot commented Feb 15, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Computability.TuringMachine [Merged by Bors] - feat: port Computability.TuringMachine Feb 15, 2023
@bors bors bot closed this Feb 15, 2023
@bors bors bot deleted the port/Computability.TuringMachine branch February 15, 2023 04:31
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@int-y1 @mo271
feat: port Computability.TuringMachine (#2125)
f41dc51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@int-y1 @dupuisf @semorrison @Komyyy