[Merged by Bors] - feat: Port Data.Nat.Choose.Central #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
casavaca
added
mathlib-port
jcommelin
reviewed
Feb 7, 2023
Mathlib/Data/Nat/Choose/Central.lean
Outdated
| -/ | ||
| def centralBinom (n : ℕ) := | ||
| (2 * n).choose n | ||
| #align nat.central_binom Nat.centralBinom | ||
|
|
||
| /-- expand centralBinom to its definition. -/ |
There was a problem hiding this comment.
Suggested change
| /-- expand centralBinom to its definition. -/ | |
| /-- expand `centralBinom` to its definition. -/ |
Also elsewhere. I applaud the fact that you want to improve documentation. But I would rather encourage you to not fix documentation while porting. Because it means an extra review duty while reviewing porting PRs. Let's stick to doing one thing at a time.
jcommelin
added
awaiting-author
I had the wrong impression that the linter would complain.
casavaca
added
awaiting-review
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
Co-authored-by: Frédéric Dupuis <dupuisf@iro.umontreal.ca>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #1091, @dupuisf 's commit is preserved in commit history.