Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Fin.Tuple.NatAntidiagonal #2170

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: port Data.Fin.Tuple.NatAntidiagonal #2170

wants to merge 10 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Feb 8, 2023

Open in Gitpod

@mo271
feat: port Data.Fin.Tuple.NatAntidiagonal
816fc1e
@mo271
Initial file copy from mathport
211495d
@mo271
automated fixes
721bbbd 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mo271
first pass
a3c8ebd
@mo271 mo271 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Feb 8, 2023
@mo271 mo271 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Feb 8, 2023
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Feb 9, 2023
@mo271 @eric-wieser
Update Mathlib/Data/Fin/Tuple/NatAntidiagonal.lean
5467850 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
jcommelin
jcommelin approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 11, 2023
bors bot pushed a commit that referenced this pull request Feb 11, 2023
@mo271 @eric-wieser @Ruben-VandeVelde
feat: port Data.Fin.Tuple.NatAntidiagonal (#2170)
388222f 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Fin.Tuple.NatAntidiagonal [Merged by Bors] - feat: port Data.Fin.Tuple.NatAntidiagonal Feb 11, 2023
@bors bors bot closed this Feb 11, 2023
@bors bors bot deleted the port/Data.Fin.Tuple.NatAntidiagonal branch February 11, 2023 09:22
mo271 added a commit that referenced this pull request Feb 18, 2023
@mo271 @eric-wieser @Ruben-VandeVelde
feat: port Data.Fin.Tuple.NatAntidiagonal (#2170)
39efa5d 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin approved these changes

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mo271 @eric-wieser @jcommelin @Ruben-VandeVelde @semorrison